Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in design_bench.oracles.tensorflow.transformer_oracle.py #24

Open
trxcc opened this issue May 16, 2024 · 2 comments
Open

Bugs in design_bench.oracles.tensorflow.transformer_oracle.py #24

trxcc opened this issue May 16, 2024 · 2 comments

Comments

@trxcc
Copy link

trxcc commented May 16, 2024

It is a minor typo. In line 335, when we conduct protected_predcict, training is not defined thus it may raise a fault. A simple fix is to add a flag when initializing the oracle. Transformer oracle is required when considering GFP task, thus I think it is necessary to fix this bug.

@brandontrabucco
Copy link
Owner

Hi trxcc,

Thanks for your interest in our benchmark!

Could you share a snippet of how you are using the transformer_oracle and how you are loading the corresponding design_bench task so I can reproduce this error?

Thanks!

-Brandon

@trxcc
Copy link
Author

trxcc commented May 26, 2024

When I attempted to reproduce the performance of the COMs for the task GFP, it was necessary to use an entry such as GFP-Transformer-v0. Additionally, a minor typo involving an undefined symbol training in line 335 triggered an error during the initialization of the oracle.

Thanks for your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants