Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseModel.php / function save() : unrelated return property #19

Open
Macadoshis opened this issue Mar 18, 2018 · 0 comments
Open

BaseModel.php / function save() : unrelated return property #19

Macadoshis opened this issue Mar 18, 2018 · 0 comments

Comments

@Macadoshis
Copy link 

// BaseModel.php
public function save() {
    ...
    return $this->id;
}

Why do you return a raw "id" property ? You should return $this->{static::get_primary_key()} at least in the Insert case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Macadoshis