Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider hiding inline search ads even in Standard blocking #28387

Closed
Yuki2718 opened this issue Feb 8, 2023 · 3 comments
Closed

Consider hiding inline search ads even in Standard blocking #28387

Yuki2718 opened this issue Feb 8, 2023 · 3 comments
Assignees
Labels
closed/wontfix feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@Yuki2718
Copy link

Yuki2718 commented Feb 8, 2023

As in brave/adblock-rust#258 (comment), and now https://www.pcworld.com/article/1502809/you-cant-trust-google-results-for-software-downloads-right-now.html too, Google ads have been a popular source of scam and malware. You can't claim to be a secure browser while is endangering majority of user by that. Vivaldi hides at least Google search ads by default (bing not as their partner tho). This should be an exception for the 1p vs 3p policy of Brave simply because of the risk, but as most of scam/malware are inserted to inline search results, maybe only these inline ads can be targeted. Safe browsing has not been blocking most of these malware sites.

@antonok-edm antonok-edm transferred this issue from brave/adblock-rust Feb 8, 2023
@antonok-edm antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 8, 2023
@antonok-edm antonok-edm self-assigned this Feb 8, 2023
@antonok-edm
Copy link
Collaborator

I think this policy is unlikely to change, for a few reasons:

  • a surprising number of non-technical users find those results to be useful and expect them to be there. Personally, I'm wary of search ads too and always use Aggressive mode, but making privacy accessible by default to a wide audience involves some tradeoffs.
  • Brave runs a search engine as well. The same "ads shown by default, hidden in aggressive mode" policy is applied across all search engines; specifically blocking competitors is not a great move in the spirit of healthy competition.
  • https://search.brave.com has been the default search engine for new Brave users for a while now, so even if Google is particularly bad at filtering out malicious content in their SERP ads, it'd have to be an explicit choice by the user to be viewing those instead.

(fwiw, adblock-rust is built as a general-purpose adblocking engine and doesn't have any special logic built-in for this kind of purpose, which is why I've moved it to the brave-browser repo)

@Yuki2718
Copy link
Author

Yuki2718 commented Feb 9, 2023

https://search.brave.com/ has been the default search engine for new Brave users for a while now

Oh, I forgot this. Okay.

@Yuki2718
Copy link
Author

https://search.brave.com/ has been the default search engine for new Brave users for a while now, so even if Google is particularly bad at filtering out malicious content in their SERP ads, it'd have to be an explicit choice by the user to be viewing those instead.

This is not true, on v1.62.162 I see Google is still default search except for incognito window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants