Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Infobar/notice for first interaction with clicked SERP ad landing page #39625

Open
tmancey opened this issue Jul 8, 2024 · 2 comments · May be fixed by brave/brave-core#25393
Open

[ads] Infobar/notice for first interaction with clicked SERP ad landing page #39625

tmancey opened this issue Jul 8, 2024 · 2 comments · May be fixed by brave/brave-core#25393
Assignees
@aseren
Labels
blocked enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 8, 2024 •
edited
Loading

https://docs.google.com/document/d/1mKpqqMGKImM7ZimK2_maUKooi3-ZQ42doVLtYgqPpgg/edit
@tmancey tmancey added enhancement privacy priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jul 8, 2024
@tmancey tmancey added this to Ads Jul 8, 2024
@github-project-automation github-project-automation bot moved this to New issues in Ads Jul 8, 2024
@tmancey tmancey moved this from New issues to To Do in Ads Jul 8, 2024
@diracdeltas
Copy link
Member

Noting that this should not be merged til brave/brave-core#24188 is done

@tmancey tmancey moved this from To Do to In progress in Ads Jul 15, 2024
@aseren aseren linked a pull request Aug 30, 2024 that will close this issue
Open
24 tasks
@aseren aseren moved this from In progress to Review in Ads Sep 4, 2024
@aseren aseren added the blocked label Oct 8, 2024
@aseren
Copy link

aseren commented Oct 8, 2024

The current issue is blocked by #40952: we need brave://ads-internals to be implemented first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
blocked enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA/Yes release-notes/exclude
Projects
Ads
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ads] Add search result ad clicked InfoBar brave/brave-core
3 participants
@diracdeltas @tmancey @aseren