Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quick search engines settings position #42291

Closed
1 of 6 tasks
deeppandya opened this issue Nov 14, 2024 · 2 comments · Fixed by brave/brave-core#26546
Closed
1 of 6 tasks

Change quick search engines settings position #42291

deeppandya opened this issue Nov 14, 2024 · 2 comments · Fixed by brave/brave-core#26546
Assignees
Labels
feature/QuickSearch QSE on Android OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@deeppandya
Copy link
Contributor

Description

Currently we are showing quick search engines option at the end in search engines settings. With this issue, we need to match the position to what we have in IOS.
We need to place quick search engines options right after Standard tab/Private tab.

Steps to reproduce

  1. Install Brave
  2. Go to settings -> Search engines
  3. Observe that Quick search engine option is at the end

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version

Brave nightly version : 1.75.9

Device

  • Brand/model: Pixel 7 pro
  • Android version: 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.74.13 or higher for 1.74.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 27, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 27, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.74.13 
Chromium: 131.0.6778.85 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the STR/TP from Change quick search engines settings position #42291 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Quick-Search Engines settings located between Private Tab and Show browser suggestions settings
  • Verified the same for fresh and upgraded profiles.
  • Verified that the Quick-Search Engines settings screen can be opened and closed without any issues.

1 2
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/QuickSearch QSE on Android OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants