Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Chat FullPage shouldn't show in SidePanel mode when restored at startup #42413

Closed
6 tasks
petemill opened this issue Nov 20, 2024 · 0 comments · Fixed by brave/brave-core#26678
Closed
6 tasks

AI Chat FullPage shouldn't show in SidePanel mode when restored at startup #42413

petemill opened this issue Nov 20, 2024 · 0 comments · Fixed by brave/brave-core#26678
Assignees
@petemill
Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Milestone
1.75.x - Nightly

Comments

@petemill
Copy link
Member

Description

AI Chat FullPage shouldn't show in SidePanel mode when restored at startup

Steps to reproduce

  1. Open several FullPage AI Chat tabs (currently chrome-untrusted://chat)
  2. Quit the browser
  3. Restart the browser

Actual result

Several or all of the FullPage AI Chat pages are in SidePanel mode (they don't have a conversation list navigation sidebar)

Expected result

They all should be restored in FullPage mode

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.32

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Requires AIChatHistory feature flag
SidePanel still being opened in SidePanel mode and not FullPage mode should be tested too
@petemill petemill self-assigned this Nov 20, 2024
@petemill petemill mentioned this issue Nov 21, 2024
Merged
25 tasks
@mattmcalister mattmcalister added browser-ai priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 21, 2024
@mattmcalister mattmcalister moved this to In Progress in Browser AI Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Nov 28, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
Browser AI
Status: Done
Milestone
1.75.x - Nightly
Development

Successfully merging a pull request may close this issue.

AI Chat fullpage UI notices and polish brave/brave-core
3 participants
@mattmcalister @petemill @brave-builds