Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom of VPN icon of vpn card is clipped #42543

Closed
1 of 6 tasks
simonhong opened this issue Nov 27, 2024 · 0 comments · Fixed by brave/brave-core#26765
Closed
1 of 6 tasks

Bottom of VPN icon of vpn card is clipped #42543

simonhong opened this issue Nov 27, 2024 · 0 comments · Fixed by brave/brave-core#26765
Assignees
@simonhong
Labels
feature/vpn OS/Desktop OS/macOS OS/Windows QA/Yes release-notes/exclude
Milestone
1.75.x - Nightly

Comments

@simonhong
Copy link
Member

Description

Image

Steps to reproduce

  1. Set purchased state
  2. Check the bottom of vpn icon of vpn card

Actual result

See the screenshot in the above description

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.52 Chromium: 131.0.6778.85 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @brave/qa-team
@simonhong simonhong self-assigned this Nov 27, 2024
simonhong added a commit to brave/brave-core that referenced this issue Nov 27, 2024
@simonhong
Fixed bottom of vpn icon of vpn card was clipped
e9401d2 
fix brave/brave-browser#42543

Wrong width/height was set. It should be 64px.
@simonhong simonhong mentioned this issue Nov 27, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 27, 2024
This was referenced Nov 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop OS/macOS OS/Windows QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging a pull request may close this issue.

Fixed bottom of vpn icon of vpn card was clipped brave/brave-core
2 participants
@simonhong @brave-builds