Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show connect button over region entry when it's current connected region #42544

Closed
3 of 6 tasks
simonhong opened this issue Nov 27, 2024 · 0 comments · Fixed by brave/brave-core#26766
Closed
3 of 6 tasks

Comments

@simonhong
Copy link
Member

Description

In the select region page in vpn panel, connect button is shown when hovered over the each region(city).
but that button doesn't need to be shown when that region entry is currently connected entry.

Steps to reproduce

  1. Connect to Italy/Milan
  2. Go to select region
  3. Hover over Italy/Milan

Actual result

Connect button is shown

Expected result

Connect button is not shown as it's current connected region

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.52 Chromium: 131.0.6778.85 (Official Build) nightly (64-bit)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @brave/qa-team @aguscruiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment