Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash adding rule into brave://settings/shields/filters #42578

Open
3 of 6 tasks
ryanbr opened this issue Nov 28, 2024 · 1 comment
Open
3 of 6 tasks

Crash adding rule into brave://settings/shields/filters #42578

ryanbr opened this issue Nov 28, 2024 · 1 comment
Labels
crash OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@ryanbr
Copy link

ryanbr commented Nov 28, 2024

Description

Adding :has-text() into brave://settings/shields/filters causes Brave to crash

Steps to reproduce

  1. Open brave://settings/shields/filters
  2. In custom filters paste ##.t-rec > .t886:has-text(cookies)
  3. Press Save
  4. Crash

Actual result

Crash Browser

Expected result

Don't crash.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Windows/Macos

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@ryanbr ryanbr added crash OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 28, 2024
@ryanbr
Copy link
Author

ryanbr commented Nov 28, 2024

brave/adblock-rust#403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanbr