Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOM] Use of placeholder attributes on fields is confusing #42585

Open
jonathansampson opened this issue Nov 28, 2024 · 1 comment
Open

[BYOM] Use of placeholder attributes on fields is confusing #42585

jonathansampson opened this issue Nov 28, 2024 · 1 comment
Assignees

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Nov 28, 2024

Description

When creating or editing a BYOM model configuration, the UI presently shows the default context size and default system prompt in the respective input elements. The values are, however, presented via the placeholder attribute for each field. This presentation may look to the end-user like the content is editable, which is not the case. If the user prefers to keep the default prompt, but with a couple changes, they are not able to do so. Any input by the user completely overwrites the placeholder text.

@BrendanEich
Copy link
Member

We shouldn't use a readonly-looking style for anything editable, but beyond style, it is odd that one cannot select (visibly) but can type to overwrite. I've never seen this style and half-joked about "HIG compliance" (old Apple folks will grok) to Sampson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants