Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change QSE settings position in search engines section #26546

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Change QSE settings position in search engines section #26546

merged 1 commit into from
Nov 14, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Nov 14, 2024 •
edited
Loading

Resolves brave/brave-browser#42291

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please follow the details from main issue.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 14, 2024
@deeppandya deeppandya added this to the 1.75.x - Nightly milestone Nov 14, 2024
@deeppandya deeppandya requested a review from samartnik November 14, 2024 05:32
@deeppandya deeppandya self-assigned this Nov 14, 2024
samartnik
samartnik approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit bbc5f7f into master Nov 14, 2024
18 checks passed
@deeppandya deeppandya deleted the change_qse_settings_position_android branch November 14, 2024 19:53
@brave-builds
Copy link
Collaborator

Released in v1.75.20

deeppandya added a commit that referenced this pull request Nov 25, 2024
@deeppandya
Merge pull request #26546 from brave/change_qse_settings_position_and…
f587803 
…roid

Change QSE settings position in search engines section
@deeppandya deeppandya mentioned this pull request Nov 25, 2024
Merged
7 tasks
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.75.44 Chromium: 131.0.6778.85 (Official Build) canary (64-bit) 
Revision	f14243b5f56477f2b635b3babf9d37521a02737e
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that Quick-Search Engines is placed right below Private Tab in Search engines settings.
  • Ensured that QSE page is opened when tapping on Quick-Search Engines.
1.74.x 1.75.44
Screenshot 2024-11-22 at 3 29 36 PM Screenshot 2024-11-25 at 11 42 11 AM

kjozwiak pushed a commit that referenced this pull request Nov 25, 2024
@deeppandya @SergeyZhukovsky
Quick search engines follow ups [Uplift to 1.74.x] (#26717)
8c571cb 
* Merge pull request #26527 from brave/change_quick_search_engines_view_color

Change quick search engine background to match with url bar color

* Merge pull request #26546 from brave/change_qse_settings_position_android

Change QSE settings position in search engines section

* Merge pull request #26547 from brave/add_youtube_in_qse_android

Add youtube in qse android

* Merge pull request #26549 from brave/qse_keyboard_behaviour_change

QSE keyboard behaviour change

* Merge pull request #26550 from brave/resolve_google_search_QSE_android

Update google search url for QSE

* Merge pull request #26648 from brave/android_qse_crash

A possible fix for a crash on showing quick search engines panel

* Merge pull request #26548 from brave/update_qse_default_search_behaviour

Update QSE default search behaviour

---------

Co-authored-by: Serg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik approved these changes

@AlexeyBarabash AlexeyBarabash Awaiting requested review from AlexeyBarabash

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging this pull request may close these issues.

Change quick search engines settings position
4 participants
@deeppandya @brave-builds @Uni-verse @samartnik