Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick search engines follow ups [Uplift to 1.74.x] #26717

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Quick search engines follow ups [Uplift to 1.74.x] #26717

merged 7 commits into from
Nov 25, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Nov 25, 2024 •
edited by kjozwiak
Loading

Uplift of #26527
Uplift of #26546
Uplift of #26547
Uplift of #26549
Uplift of #26550
Uplift of #26648
Uplift of #26548
Resolves brave/brave-browser#42267
Resolves brave/brave-browser#42291
Resolves brave/brave-browser#42292
Resolves brave/brave-browser#42186
Resolves brave/brave-browser#42384
Resolves brave/brave-browser#42380
Resolves brave/brave-browser#42296

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

deeppandya and others added 7 commits November 24, 2024 18:48
@deeppandya
Merge pull request #26527 from brave/change_quick_search_engines_view…
fae6bec 
…_color

Change quick search engine background to match with url bar color
@deeppandya
Merge pull request #26546 from brave/change_qse_settings_position_and…
f587803 
…roid

Change QSE settings position in search engines section
@deeppandya
Merge pull request #26547 from brave/add_youtube_in_qse_android
fe28d34 
Add youtube in qse android
@deeppandya
Merge pull request #26549 from brave/qse_keyboard_behaviour_change
2516eb5 
QSE keyboard behaviour change
@deeppandya
Merge pull request #26550 from brave/resolve_google_search_QSE_android
21345f6 
Update google search url for QSE
@SergeyZhukovsky @deeppandya
Merge pull request #26648 from brave/android_qse_crash
cf975c5 
A possible fix for a crash on showing quick search engines panel
@deeppandya
Merge pull request #26548 from brave/update_qse_default_search_behaviour
2cbec19 
Update QSE default search behaviour
@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 25, 2024
@deeppandya deeppandya added this to the 1.74.x - Beta milestone Nov 25, 2024
@deeppandya deeppandya self-assigned this Nov 25, 2024
@deeppandya deeppandya requested a review from a team as a code owner November 25, 2024 00:52
kjozwiak
kjozwiak approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26527 (comment), #26546 (comment), #26547 (comment), #26549 (comment), #26550 (comment), #26648 (comment) & #26548 (comment).

@kjozwiak kjozwiak merged commit 8c571cb into 1.74.x Nov 25, 2024
16 checks passed
@kjozwiak kjozwiak deleted the quick_search_engines_followup_1.74.x branch November 25, 2024 19:35
@brave-builds
Copy link
Collaborator

Released in v1.74.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.74.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@deeppandya @brave-builds @kjozwiak @SergeyZhukovsky