Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Improve new playlist UI responsiveness #26726

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 25, 2024

This change adds async versions to many synchronous AVKit operations that were being called in Playlist such as loading the duration of the video, fetching the download state, and setting the duration in PlayerModel once per load rather than have it computed.

Resolves brave/brave-browser#42501

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In addition to STR in the issue, also test these things on both old and new playlist:

  • Downloading a video for offline correctly fetches the duration and displays it correctly in the list

This change adds async versions to many synchronous AVKit operations that were being called in Playlist such as loading the duration of the video, fetching the download state, and setting the duration in PlayerModel once per load rather than have it computed.
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 25, 2024
@kylehickinson kylehickinson self-assigned this Nov 25, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner November 25, 2024 17:24
@kylehickinson kylehickinson merged commit 91ea4b6 into master Nov 25, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-new-playlist-performance branch November 25, 2024 18:41
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 25, 2024
brave-builds added a commit that referenced this pull request Nov 25, 2024
brave-builds added a commit that referenced this pull request Nov 25, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.50

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.0 using version 1.75 (52)

old UI new UI saving offline
IMG_8082 IMG_8077 IMG_8079

kjozwiak pushed a commit that referenced this pull request Nov 26, 2024
kjozwiak pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist UI can be unresponsive and hang
4 participants