Bump version to 1.1.2 in library.properties #57
Conversation
Reflect version change in library.properties so PlatformIO's crawler will update this library.
Logic is intended to check how many bars to draw by examining 2 bar positions at a time. Previous version the second conditional was always false (because if barsOn-2*i+1 is not >=0 in the first conditional it certainly won't be >=1 in the second. Instead of >=1, the second conditional needed to be >=-1 in the prior logic. Simplifying the logic so that the value being checked in the conditional corresponds directly to the number of bars to light solves the problem and makes the flow much more directly understandable.
|
It is odd that I don't find information about it in the PlatformIO documentation, but here is an example where the CEO of PlatformIO requested a tag creation in a library repository, so I think it must be the case: arduino-libraries/NTPClient#152 (comment) I know for certain 'this is how the Arduino Library Manager works. The 1.1.1 release is also missing from Library Manager due to this, so making a new tag with correct metadata will be beneficial regardless. Fixes #60 |
|
It's good that you finally fixed #50 but the bar logic is bugged, which is why I patched it also. The second conditional is always false and the code beneath it unreachable. If the expression (barsOn-2*(i+1)) wasn't >=0 in the first conditional, then it certainly won't be >=1 in the second conditional. The two ways to fix this are to change the second conditional to >=-1 (negative one) or to use my simplification of the logic. As is, the bars demo only ever moves by 2 lines at a time. |
Reflect version change in library.properties so PlatformIO's crawler will update this library.
PlatformIO still has version 1.1.0 simply because library.properties still reads that the current version is 1.1.0 instead of 1.1.1. Updating this will allow people to install the current release through PlatformIO again.
(Bumped version number to 1.1.2 not 1.1.1 because this change will also require a new release to accompany it, assuming I'm correct that PlatformIO's crawler only looks at releases).
Closes #50
Proper fix vs #52