Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printLevelVertical only prints double bars, never single bars #59

Open
tofof opened this issue May 10, 2022 · 0 comments · May be fixed by #58
Open

printLevelVertical only prints double bars, never single bars #59

tofof opened this issue May 10, 2022 · 0 comments · May be fixed by #58

Comments

@tofof
Copy link

tofof commented May 10, 2022

The logic for printing single bars is erroneous; the condition will always be false when that code is reached (>=0 has to be false already, so obviously >=1 will be false).

This can be easily verified using the FunPrintLevel example and changing the step size to 1, along with a Serial.print of the current level. The first bar should draw at 13, but no bars appear until a double bar at 25, and then another double bar at 50, etc.

Fixed by included PR #58.

@tofof tofof linked a pull request May 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant