Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newline for plaintext writer #23

Open
flibustenet opened this issue Jul 24, 2014 · 2 comments
Open

newline for plaintext writer #23

flibustenet opened this issue Jul 24, 2014 · 2 comments

Comments

@flibustenet
Copy link

It seems that newline parameter is not used. I can make a pull request, but it's my first use of this tools, so please confirm that i should just replace "\n" by self.newline.

It seems also that it's a bug from rtf to text between newline from paragraph and newline from newline... But i must investigate to see exactly why.

@brendonh
Copy link
Owner

Yes, the newline parameter does seem to be unused, and probably should be. Please make a pull request.

I'm not sure what you mean by "a bug from rtf to text between newline from paragraph and newline from newline". Can you give me an example?

@flibustenet
Copy link
Author

{\rtf1\ansi\ansicpg1252\deff0\deflang1036{\fonttbl{\f0\fswiss\fcharset0 Arial;}}
{\*\generator Msftedit 5.41.15.1515;}\viewkind4\uc1\pard\f0\fs20 a\par
b\par
c\par
\par
d\par
e\par
}

with clean_paragraphs=False the result is

a

b

c



d

e

and it should be

a
b
c

d
e

Don't know if it's a problem with plaintext writer (it's ok if i remove self.target.write('\n') from go or from paragraph) or if the problem come from rtf reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants