-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random sampling using other distributions on SO(3) (ex. Von Mises Fisher) #6
Comments
Thanks for the kind words!! I did think about including distributions like VMF and Bingham at one point and would be open to it, the main reason this never happened is that tangent-space Gaussians have been lower-effort and sufficient for my own use cases. Two things I'm wondering:
|
@brentyi Re (1) -- that's a fair point. Honestly, I don't know how large a dependency TFP is. I'd really prefer to not have to pull in all of TensorFlow for my own package. This is something I'll have to investigate. For (2) -- the main functionality that I'm interested in is sampling and scoring. I would be wrapping distributions for use in a probabilistic programming context, so evaluating |
(Also, re -- TFP: I don't fully understand the "substrate" layer. My stuff is all in pure JAX anyways, so I've been reaching for distributions that are also in pure JAX -- I didn't really investigate integration with TFP, although the documentation seems to indicate a high quality for their distributions. If I could somehow figure out how to just depend on distributions + the JAX substrate, it would basically solve my motivating problem) |
Just to be fully transparent -- I'm interested in functionality like this: https://github.com/probcomp/GenDirectionalStats.jl But in JAX. If these distributions seem interesting and in scope, I can likely contribute a PR with my colleague. |
On If a contribution to |
Cool! -- I'll play a bit with |
Hi -- first off, this package is incredible. Thank you.
Second, have you considered adding further random sampling functionality (for other distributions on spaces of rotations). In the title, I referred to the VMF distribution.
If you think this functionality should live elsewhere, totally fine! If you're curious and open to it, I may setup a PR and move some of the functionality from a package I'm working on to here.
The text was updated successfully, but these errors were encountered: