Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brian2cuda to use current brian2 master #22

Closed
denisalevi opened this issue Jun 9, 2016 · 4 comments
Closed

Update brian2cuda to use current brian2 master #22

denisalevi opened this issue Jun 9, 2016 · 4 comments
Assignees

Comments

@denisalevi
Copy link
Member

There seem to be some changes in the spikequeue in brian2.

Following PRs from brian2 referenced possible changes for brian2cuda:

@denisalevi
Copy link
Member Author

The synapse generation has changed (brian-team/brian2#600). But since this is happening on host side in brian2cuda currently, we should be able to use the algorithm from the corresponding cpp template.

@denisalevi
Copy link
Member Author

@moritzaugustin Are we updating to brian2 2.0 as new frozen or are we trying to stay with current master? Brian2genn depends on brian2>=2.0, so this looks like they keep following brian2 master, which is also stated here (brian-team/brian2genn#25)

@denisalevi denisalevi added this to the Release 1.0 milestone Nov 15, 2016
@moritzaugustin
Copy link
Contributor

let's have brian2.0 as new frozen commit which might seem unnecessary at the moment but we want to follow brian2 master later if incompatible changes happen (let's discuss then again whether to have 2 branches in this case)

@denisalevi
Copy link
Member Author

We are now following brian2 commit fadc6a0aeb90d1b4d343470628457d8561536f67. There are still a few tests failing from the brian2 test suite, but they are not of high priority right now. I have opened issues for those (#46, #47, #48, #49, #50, #52 ).
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants