Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Brian2 update PR broke benchmark scripts #304

Open
denisalevi opened this issue Oct 28, 2022 · 1 comment
Open

Recent Brian2 update PR broke benchmark scripts #304

denisalevi opened this issue Oct 28, 2022 · 1 comment

Comments

@denisalevi
Copy link
Member

I just realized that the Brian2 update (#249 ) broke the benchmark scripts because some changes in brian2.diff got lost.

See my comment here: #249 (comment)

@mstimberg
Copy link
Member

I wonder whether it is actually worth fixing this in brian2.diff – maybe it is just simpler to move the test/features to brian2cuda in the "correctly diffed" version and adapt the scripts to use these instead of the ones from brian2? We could then get rid of brian2.diff completely, which would also make future updates easier. You already proposed this (#249 (comment)) but considered it wouldn't be worth the effort right now. But maybe the effort estimation just changed and it might be easier than fixing brian2.diff... 😬 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants