Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate javax.portlet:portlet-api and portlet support #305

Open
cyb3r4nt opened this issue Jan 19, 2023 · 0 comments
Open

Deprecate javax.portlet:portlet-api and portlet support #305

cyb3r4nt opened this issue Jan 19, 2023 · 0 comments

Comments

@cyb3r4nt
Copy link
Contributor

JsonRpcServer depends on the javax.portlet:portlet-api and requires this to be in the classpath even if portlet support is not used.
At the same time, portlet applications are not very popular nowadays,
and probably there are no many users who actually need this.
My personal opinion is that majority of users do not use that feature,
and are obligated to bring javax.portlet:portlet-api only because jsonrpc4j needs this.

Please comment and vote if you still need that Java portlets support.

Portlet methods are actually quite short:
https://github.com/briandilley/jsonrpc4j/blob/1.6.0/src/main/java/com/googlecode/jsonrpc4j/JsonRpcServer.java#L76-L105

Active users may just inline this logic into their own projects,
and use other streaming method to handle those requests:
https://github.com/briandilley/jsonrpc4j/blob/1.6.0/src/main/java/com/googlecode/jsonrpc4j/JsonRpcBasicServer.java#L230-L260

The plan may be to mark it as @Deprecated(forRemoval = true),
and remove this in one of the future versions.

cyb3r4nt added a commit to cyb3r4nt/jsonrpc4j that referenced this issue Jan 19, 2023
…avax.portlet.ResourceRequest, javax.portlet.ResourceResponse) as deprecated

Added @deprecated marker and wrote a comment in the Javadoc

Signed-off-by: cyb3r4nt <[email protected]>
cyb3r4nt added a commit to cyb3r4nt/jsonrpc4j that referenced this issue Jan 19, 2023
…avax.portlet.ResourceRequest, javax.portlet.ResourceResponse) as deprecated

Added @deprecated marker and wrote a comment in the Javadoc

Signed-off-by: cyb3r4nt <[email protected]>
briandilley added a commit that referenced this issue May 24, 2023
#305: Deprecate portlet-api support in the JsonRpcServer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant