Prettier #55
Closed
Prettier #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tslint-config-prettier is necessary to make prettier play nice with tslint.
this commit formats src/* and tests/* according to prettier so that it would be a starting point for all commits from now on ( if not done prettier would do it anayway once a change occurs in one of those files, and cloud the actual change made by that commit)
the function keyword makes code more readable when the function's body is large, one tends to lose track while reading large arrow functions.
briangonzalez
requested changes
Feb 5, 2019
|
|
||
| img.onerror = errorHandler | ||
| img.onabort = errorHandler | ||
| img.src = src | ||
| }) | ||
| } | ||
|
|
||
| export const getCounts = (data: Uint8ClampedArray, ignore: string[]): [] => { | ||
| const countMap = {} | ||
| export function getCounts(data: Uint8ClampedArray, ignore: string[]): [] { |
There was a problem hiding this comment.
@a-hariti What's the thinking behind changing this to a function?
There was a problem hiding this comment.
TLDR it is a matter of preference.
I think it is more readable IMHO, arrow functions are more suitable for one-liners like someNumbers.map(n => n*2), but once a functions get as big as this one, it becomes more difficult to keep track of the one you are reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds
prettierto the build system, formats the codebase accordingly, and suggests some code refactoring, feel free tocherry-pick.fixes #51