Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll_object in ui/object_details.py gets passed weird stuff #225

Open
jscheidtmann opened this issue Aug 28, 2024 · 2 comments
Open

scroll_object in ui/object_details.py gets passed weird stuff #225

jscheidtmann opened this issue Aug 28, 2024 · 2 comments

Comments

@jscheidtmann
Copy link
Contributor

jscheidtmann commented Aug 28, 2024

See https://github.com/brickbots/PiFinder/pull/222/files#r1732015625

Need to investigate where this is coming from.
brickbots wrote: "[it] might be nice to figure out where this is coming from. I'm guess it's a side effect of the nearby sort?"

Repository owner deleted a comment Aug 28, 2024
@mrosseel
Copy link
Collaborator

mrosseel commented Aug 28, 2024

Nearby sorting is using numpy for speed, we should either use numpy for all sorting stuff or convert nearby sort to normal list. I'm currently reworking sorting so it's probably best to revisit this after the sorting changes are done.
(my PR will set default sorting orders for each menu item, and probably allow the user to override them in the settings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mrosseel @jscheidtmann and others