Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving composed nodes does not remove redundant relationship #126

Open
p-m-p opened this issue Apr 25, 2017 · 0 comments
Open

Moving composed nodes does not remove redundant relationship #126

p-m-p opened this issue Apr 25, 2017 · 0 comments

Comments

@p-m-p
Copy link

p-m-p commented Apr 25, 2017

We've encountered a situation where we move a node from one relationship to another but the redundant relationship is not removed. As an example with the below compositions LINE_MANAGER is updated and the existing node is then set as a FORMER_LINE_MANAGER. There should only be one line manager but we end up with two as this line https://github.com/brikteknologier/seraph-model/blob/master/lib/write.js#L229 does not check how the target nodes are related in the deletion phase.

Model.compose(Manager, 'lineManager', 'LINE_MANAGER');
Model.compose(Manager, 'formerLineManagers', 'FORMER_LINE_MANAGER', { many: true });

We've coded around the issue but just wanted to make you aware if you are actively maintaining this project.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant