From 60cf2983c4cbdf6983b63963d036d059986dc9f4 Mon Sep 17 00:00:00 2001 From: Raissa North Date: Mon, 25 Jun 2018 14:26:06 +1200 Subject: [PATCH] Fix spacing in module details when no description is provided --- client/dist/styles/bundle.css | 2 +- client/src/components/ModuleDetails/ModuleDetails.scss | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/client/dist/styles/bundle.css b/client/dist/styles/bundle.css index 0a8fbc8..38d4e21 100644 --- a/client/dist/styles/bundle.css +++ b/client/dist/styles/bundle.css @@ -1 +1 @@ -.site-alert{margin-top:-.76925rem;margin-bottom:1.5385rem}.site-summary h3{margin:8px 0 4px}.site-summary td{vertical-align:middle}.package-summary__anchor{display:block}.package-summary__anchor,.package-summary__anchor:active,.package-summary__anchor:hover{color:inherit;text-decoration:inherit}.package-summary__description{display:block}.gridfield-dropdown-filter button{display:none}.site-summary__more-info{color:inherit;margin:.5385rem}.site-summary__more-info:hover{text-decoration:none;color:inherit}.package-summary__module-info-trigger{padding:0}.package-summary__details-header{padding-bottom:0;padding-top:1.2308rem;background:0;border:0}.package-summary__security-alerts{margin-top:1.2308rem;margin-bottom:.6154rem}.package-summary__security-alerts h4{margin-bottom:.6154rem}.package-summary__security-alerts a{padding:0}.package-summary__security-alerts a,.package-summary__security-alerts a:hover{background:none;color:inherit;text-decoration:underline}.package-summary__details-header{display:-webkit-box;display:-webkit-flex;display:flex}.package-summary__details-header a{text-decoration:none;color:#43536d}.health-indicator{display:-webkit-box;display:-webkit-flex;display:flex;position:absolute;right:.75rem;font-weight:400;font-size:.9rem}.health-indicator__symbol{position:relative;display:inline-block;border-radius:50%;width:12px;height:12px;border:2px solid;margin-right:3px;top:0}.health-indicator__symbol--green{background-color:#3fa142;border-color:#3fa142}.health-indicator__symbol--grey{background-color:#ced5e1;border-color:#ced5e1}.health-indicator__symbol--half{top:2px;left:2px;height:4px;width:8px;border-radius:4px 4px 0 0;-moz-border-radius:4px 4px 0 0;-webkit-border-radius:4px 4px 0 0;background-color:#fff} \ No newline at end of file +.site-alert{margin-top:-.76925rem;margin-bottom:1.5385rem}.site-summary h3{margin:8px 0 4px}.site-summary td{vertical-align:middle}.package-summary__anchor{display:block}.package-summary__anchor,.package-summary__anchor:active,.package-summary__anchor:hover{color:inherit;text-decoration:inherit}.package-summary__description{display:block}.gridfield-dropdown-filter button{display:none}.site-summary__more-info{color:inherit;margin:.5385rem}.site-summary__more-info:hover{text-decoration:none;color:inherit}.package-summary__module-info-trigger{padding:0}.package-summary__details-header{padding-bottom:0;padding-top:1.2308rem;background:0;border:0}.package-summary__security-alerts{margin-top:1.2308rem;margin-bottom:.6154rem}.package-summary__security-alerts h4{margin-bottom:.6154rem}.package-summary__security-alerts a{padding:0}.package-summary__security-alerts a,.package-summary__security-alerts a:hover{background:none;color:inherit;text-decoration:underline}.package-summary__details-header{display:-webkit-box;display:-webkit-flex;display:flex;min-width:12rem}.package-summary__details-header a{text-decoration:none;color:#43536d}.health-indicator{display:-webkit-box;display:-webkit-flex;display:flex;position:absolute;right:.75rem;font-weight:400;font-size:.9rem}.health-indicator__symbol{position:relative;display:inline-block;border-radius:50%;width:12px;height:12px;border:2px solid;margin-right:3px;top:0}.health-indicator__symbol--green{background-color:#3fa142;border-color:#3fa142}.health-indicator__symbol--grey{background-color:#ced5e1;border-color:#ced5e1}.health-indicator__symbol--half{top:2px;left:2px;height:4px;width:8px;border-radius:4px 4px 0 0;-moz-border-radius:4px 4px 0 0;-webkit-border-radius:4px 4px 0 0;background-color:#fff} \ No newline at end of file diff --git a/client/src/components/ModuleDetails/ModuleDetails.scss b/client/src/components/ModuleDetails/ModuleDetails.scss index de0a8d5..8412ad8 100644 --- a/client/src/components/ModuleDetails/ModuleDetails.scss +++ b/client/src/components/ModuleDetails/ModuleDetails.scss @@ -6,17 +6,17 @@ // Remove the background from the default popover header .package-summary__details-header { padding-bottom: 0; - padding-top: $popover-padding; + padding-top: $spacer; background: 0; border: 0; } .package-summary__security-alerts { - margin-top: $popover-padding; - margin-bottom: $popover-padding * .5; + margin-top: $spacer; + margin-bottom: $spacer * .5; h4 { - margin-bottom: $popover-padding * .5; + margin-bottom: $spacer * .5; } // Undoing the default styles that come for .popover-body a from admin module @@ -35,6 +35,7 @@ } .package-summary__details-header { display: flex; + min-width: 12rem; a { text-decoration: none;