Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembly.assemble_spades: added option to drop contigs shorter than given length. #889

Merged
merged 3 commits into from
Oct 22, 2018

Conversation

notestaff
Copy link
Contributor

assembly.assemble_spades: added option to drop contigs shorter than given length (for #874)

@notestaff notestaff self-assigned this Oct 18, 2018
Copy link
Member

@tomkinsc tomkinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It may be helpful to also expose the option in the assembly task within tasks_assembly.wdl.
SPAdes is not yet the default in the WDL assembly workflow, but with this change perhaps it should be. (?)

@notestaff notestaff closed this Oct 22, 2018
@notestaff notestaff reopened this Oct 22, 2018
@notestaff
Copy link
Contributor Author

travis-ci seems in odd state -- usually there's a pointer to the build in progress. anyone seen this before / know the fix?

@tomkinsc
Copy link
Member

From their status page, it looks like there are problems between TravisCI and GitHub:
https://www.traviscistatus.com/

@notestaff notestaff merged commit fbf6003 into master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants