Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #38

Open
brohrer opened this issue Sep 6, 2018 · 1 comment
Open

Add type hints #38

brohrer opened this issue Sep 6, 2018 · 1 comment
Labels
enhancement entrypoint A good first task if you are just coming to the project and would like to get involved. wishlist A would-be-nice enhancement.

Comments

@brohrer
Copy link
Owner

brohrer commented Sep 6, 2018

Python type hints provide a nice bit of built-in documentation and, when an appropriate linter is used, an extra catch for subtle bugs. Adding them would make the code a bit stronger.
@brohrer brohrer added enhancement entrypoint A good first task if you are just coming to the project and would like to get involved. wishlist A would-be-nice enhancement. labels Sep 6, 2018
@jletey
Copy link

jletey commented Sep 20, 2018

If you are going to do this, may I suggest mypy, since it is an incredibly powerful linter for type hints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement entrypoint A good first task if you are just coming to the project and would like to get involved. wishlist A would-be-nice enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brohrer @jletey