Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Require LineIcons #8

Open
sshaw opened this issue Jan 21, 2022 · 0 comments
Open

Don't Require LineIcons #8

sshaw opened this issue Jan 21, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sshaw
Copy link

sshaw commented Jan 21, 2022

One of the great things about this library is its size. Unfortunately it depends on LineIcons, whose CSS is larger that both this library's CSS and JS.

One can exclude LineIcons but then the X to close the banner is not visible. One must then add something like:

.lni-close::after {
    content: 'X';
}

I would be great to have defaults that don't require an external library.

@brookesb91 brookesb91 added the good first issue Good for newcomers label Jan 25, 2022
@brookesb91 brookesb91 self-assigned this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants