Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-forge should ONLY make the build/ folder #424

Open
RobertGemmaJr opened this issue Mar 1, 2024 · 2 comments · Fixed by #469
Open

electron-forge should ONLY make the build/ folder #424

RobertGemmaJr opened this issue Mar 1, 2024 · 2 comments · Fixed by #469
Assignees
@RobertGemmaJr
Labels
4.0 Versioning: Issue in regards to version 4.0.0 release

Comments

@RobertGemmaJr
Copy link
Member

RobertGemmaJr commented Mar 1, 2024 •
edited
Loading

Currently it's packaging everything in the repo, include the service account and things like that. May also need:

  • package.json
  • package-lock.json
  • node_modules/
@RobertGemmaJr RobertGemmaJr added the 3.3 Versioning: Issue in regards to version 3.3 release label Mar 1, 2024
@RobertGemmaJr RobertGemmaJr self-assigned this Mar 1, 2024
@RobertGemmaJr RobertGemmaJr added 3.4 Versioning: Issue in regards to version 3.4 release 3.5 and removed 3.3 Versioning: Issue in regards to version 3.3 release 3.4 Versioning: Issue in regards to version 3.4 release 3.5 labels Mar 20, 2024
@RobertGemmaJr
Copy link
Member Author

Looks like they have a webpack plugin! Will have to npm eject from create-create-scripts? https://www.electronforge.io/config/plugins/webpack

@RobertGemmaJr
Copy link
Member Author

Honestly it might be easier to switch to vite at this point? Their setup looks a lot cleaner
https://www.electronforge.io/config/plugins/vite#native-node-modules

@RobertGemmaJr RobertGemmaJr added 4.0 Versioning: Issue in regards to version 4.0.0 release and removed 3.4 Versioning: Issue in regards to version 3.4 release labels Apr 24, 2024
@RobertGemmaJr RobertGemmaJr removed their assignment Apr 24, 2024
@RobertGemmaJr RobertGemmaJr self-assigned this May 14, 2024
@RobertGemmaJr RobertGemmaJr linked a pull request May 14, 2024 that will close this issue
BREAKING CHANGE: Switch to vite with electron-forge #469
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertGemmaJr RobertGemmaJr

Labels
4.0 Versioning: Issue in regards to version 4.0.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: Switch to vite with electron-forge brown-ccv/honeycomb
1 participant
@RobertGemmaJr