You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
on M series Macs, arch should be set to linux/arm64 to avoid emulation and hence performance degradation in docker
linux/arm64 still don't have google-stable packages, hence
- docker file should switch to chromium installation as chromium for arm64 is indeed available
- all reference to google-chrome browser in python code should be changed to point to chromium
in order to avoid race condition on VNC port usage
- websocket port and VNC port should be changed to 6081 and 5901 (or any other values other than the default ones)
- since the container needs to start 3 different services (supervisor.d, VNC and noVNC with websockify) but docker supports only 1 CMD run, it's better to invoke ENTRYPOINT ["/entrypoint.sh"] with a shell script that does that
In attchment, dockerfile, docker-compose.yml and entrypoint.sh files purposely amended.
I've created a PR #154 implementing the suggested changes including ARM64 support, Chromium switch, and port conflict fixes. Looking forward to review and feedback.
Rationale:
on M series Macs, arch should be set to linux/arm64 to avoid emulation and hence performance degradation in docker
linux/arm64 still don't have google-stable packages, hence
- docker file should switch to chromium installation as chromium for arm64 is indeed available
- all reference to google-chrome browser in python code should be changed to point to chromium
in order to avoid race condition on VNC port usage
- websocket port and VNC port should be changed to 6081 and 5901 (or any other values other than the default ones)
- since the container needs to start 3 different services (supervisor.d, VNC and noVNC with websockify) but docker supports only 1 CMD run, it's better to invoke ENTRYPOINT ["/entrypoint.sh"] with a shell script that does that
In attchment, dockerfile, docker-compose.yml and entrypoint.sh files purposely amended.
Dockerfile.txt
docker-compose.yml.txt
entrypoint.sh.txt
Please notice that the resulting container will work but the python app won't since this is still expecting google-chrome.
Thanks for your precious work and congrats for the project.
The text was updated successfully, but these errors were encountered: