Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - M series Macs require dedicated docker image #152

Open
th3f001 opened this issue Jan 25, 2025 · 1 comment
Open

Proposal - M series Macs require dedicated docker image #152

th3f001 opened this issue Jan 25, 2025 · 1 comment

Comments

@th3f001
Copy link

th3f001 commented Jan 25, 2025

Rationale:

  • on M series Macs, arch should be set to linux/arm64 to avoid emulation and hence performance degradation in docker

  • linux/arm64 still don't have google-stable packages, hence
    - docker file should switch to chromium installation as chromium for arm64 is indeed available
    - all reference to google-chrome browser in python code should be changed to point to chromium

  • in order to avoid race condition on VNC port usage
    - websocket port and VNC port should be changed to 6081 and 5901 (or any other values other than the default ones)
    - since the container needs to start 3 different services (supervisor.d, VNC and noVNC with websockify) but docker supports only 1 CMD run, it's better to invoke ENTRYPOINT ["/entrypoint.sh"] with a shell script that does that

In attchment, dockerfile, docker-compose.yml and entrypoint.sh files purposely amended.

Dockerfile.txt

docker-compose.yml.txt

entrypoint.sh.txt

Please notice that the resulting container will work but the python app won't since this is still expecting google-chrome.

Thanks for your precious work and congrats for the project.

@Aristide021
Copy link

I've created a PR #154 implementing the suggested changes including ARM64 support, Chromium switch, and port conflict fixes. Looking forward to review and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants