[Fix] return valid values on multi-byte-wide TypedArray input #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 17, 2024
ljharb
reviewed
Nov 17, 2024
ljharb
force-pushed
the
chalker/multibyte/0
branch
from
edd4918
to
8fd1364
Compare
ljharb
approved these changes
Nov 17, 2024
ljharb
changed the title
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js supports any TypedArray or DataView as input, this lib miscalculated on e.g. Uint16Arrays
This patch fixes that
Uint8Arrayis checked with typeof inindex.jsSupport for historic Node.js versions on non-Uint8Array Buffer impls and old https://npmjs.com/buffer versions in environments without proper Uint8Array is kept at best-effort (will work on everything that both it and Node.js worked correctly on but will throw on unsupported values, i.e. wide typed arrays when Buffer is not a subclass of Uint8Array)