Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.version is undefined bug fix #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WilliamBerlin76
Copy link

process.version is currently undefined which is breaking an app that I'm working on for myself and other windows users on my team.

processVersion
processversionundefined

Switching if from process.version to global.process.version fixes it.

@jopicornell
Copy link

I'm facing this issue when running browser tests. The problem is that webpack injects the variables, when compiling, so global and process are different. global is the node and process is the browser process.

@BogdanW3
Copy link

BogdanW3 commented Jun 6, 2024

@calvinmetcalf Sorry for the completely random ping, but I stumbled upon all this today and you seemed like you were the last active reviewer on this code.
Per pull request #92, process.version was changed to global.process.version in the checks, but the actual access here wasn't changed. This pull requests seems to be the earliest of the multiple requests that would fix this problem.
(Other pull requests are #101, #104, and #116) (Also mentioned in issues #102 and #103)
I have found this one-line change to fully fix my current problems, so it'd be great to have it on npm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants