-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires yamlparser but yamlparser is not a dependency in package.json #30
Comments
This issue is not with browserslist-useragent but rather with one of its dependencies, useragent: 3rd-Eden/useragent#129 |
More generally, if you follow the comments, it suggests that you'll be putting a 200kb regex into your client-side JS, which could induce major slowdown. Personally I've opted for a short function just detecting the main browser causing issues (ie 10 and under) |
I think this package is quite needed, but it is currently broken due to this bug. |
So would it be enough if I add |
We ended up forking it and updating dependencies on our own. So it's not needed for us, but other might need it. |
Since yamlparser is required by useragent to be able to run browserslist-useragent, can you add yamlparser as a dependency or peer dependency to your package.json?
The text was updated successfully, but these errors were encountered: