Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires yamlparser but yamlparser is not a dependency in package.json #30

Closed
kb-coder opened this issue Nov 6, 2018 · 5 comments
Closed

Comments

@kb-coder
Copy link

kb-coder commented Nov 6, 2018

Since yamlparser is required by useragent to be able to run browserslist-useragent, can you add yamlparser as a dependency or peer dependency to your package.json?

@jackkinsella
Copy link

This issue is not with browserslist-useragent but rather with one of its dependencies, useragent: 3rd-Eden/useragent#129

@jackkinsella
Copy link

More generally, if you follow the comments, it suggests that you'll be putting a 200kb regex into your client-side JS, which could induce major slowdown. Personally I've opted for a short function just detecting the main browser causing issues (ie 10 and under)

@carpben
Copy link

carpben commented Mar 25, 2019

I think this package is quite needed, but it is currently broken due to this bug.
Currently this package doesn't work out of the box, and considering @jackkinsella post, not sure how to solve it.
I'd be happy to hear from Browserslist admins and contributors on this matter.

@pastelsky
Copy link
Collaborator

So would it be enough if I add yamlparser as a dependency here? Is request not needed?

@kb-coder
Copy link
Author

We ended up forking it and updating dependencies on our own. So it's not needed for us, but other might need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants