Skip to content
This repository has been archived by the owner on Mar 12, 2023. It is now read-only.

Can't choose gnome version greater than 3x. #18

Open
bweston6 opened this issue Mar 4, 2022 · 4 comments
Open

Can't choose gnome version greater than 3x. #18

bweston6 opened this issue Mar 4, 2022 · 4 comments

Comments

@bweston6
Copy link

bweston6 commented Mar 4, 2022

The regular expression that defines GNOME_VERSION can't accept the latest gnome 40+ version numbers. The argument order may need reworking as "41", for example, is both a valid EXTENSION_ID and GNOME_VERSION.

@brunelli
Copy link
Owner

brunelli commented Mar 5, 2022

Hi, PR #17 should have fixed this. Could you please try the latest version from master?

@bweston6
Copy link
Author

bweston6 commented Mar 6, 2022

Just tried from master and the issue is still present. --update does work much better in this version though so I don't need to specify GNOME_VERSION numbers anymore.

Either way, with Gnome 40+, the commands like the following don't produce the expected result and are ambiguous:

./gnome-shell-extension-installer 4135 41

The intention of the command was to install Espresso (4135) targeting gnome version 41, however this installs both Espresso (4135) and Permanent Notifications (41). Have a look at line 511 for the regular expression I was talking about.

@brunelli
Copy link
Owner

brunelli commented Mar 6, 2022

Have a look at line 511 for the regular expression I was talking about

Oh, you're right! Unfortunately, I don't think there's an easy fix for this, the arg parsing logic would have to be rewritten.

I won't be able to do that in the near future, but I can accept a PR if you're willing to work on this.

@bweston6
Copy link
Author

bweston6 commented Mar 6, 2022

No problem. I'll have a look if I have some free time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants