Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add favicon for Getit #185

Closed
AkashPaloju opened this issue Jun 6, 2024 · 3 comments · Fixed by #188
Closed

[Feature Request]: Add favicon for Getit #185

AkashPaloju opened this issue Jun 6, 2024 · 3 comments · Fixed by #188
Assignees
Labels

Comments

@AkashPaloju
Copy link
Collaborator

AkashPaloju commented Jun 6, 2024

Is your feature request related to a problem? Please describe.

Currently, Getit lacks a favicon. Having a favicon offers numerous benefits for a web application.

Describe the solution you'd like

Add the favicon shown in the 'Finalised' section in this figma
https://www.figma.com/design/5Hs4DlvyJJWjQB9K7Fh0CY/Getit?node-id=85-727&t=8HJ1iB0tvEkwQimf-0

Describe alternatives you've considered

No response

Developer Help

Refer this to know more about a favicon - https://www.bluehost.com/blog/what-is-a-favicon/#Where_do_favicons_appear

General notes for Developers:

Once you have a good understanding of the issue, you can ask for it to be assigned to you by leaving a comment as follows: Explain clearly how you'd tackle the issue at a minimum, point to which file(s) (mention their links in the repo) you'd modify, and describe the changes you'd make. If creating new files is necessary, specify where you would place them and outline the content you would add to resolve the issue.

If your explanation makes sounds good, we'll assign the issue to you. Once assigned, feel free to submit a PR.

@AkashPaloju AkashPaloju added enhancement New feature or request good first issue Good for newcomers Difficulty : Easy BSoC'24 labels Jun 6, 2024
@yashpatil641
Copy link
Contributor

yashpatil641 commented Jun 6, 2024

@AkashPaloju i want to work on this issue, i will be adding fevicon.svg file in public folder and making changes in the nuxt.config.js or index.vue file to add favicon given in the figma file

@aniket0742
Copy link

@AkashPaloju Sir, I would like to work on this issue regarding addition of favicon to the GetIt website. Based on the finalized favicon provided in the Figma file, I will make changes in the index file and implement the required changes.
Thank You.

@Kushdapush
Copy link
Collaborator

@yashpatil641 Go on start working on this 👍
@aniket0742 we will be releasing some more issues so stay tuned...

@AkashPaloju AkashPaloju linked a pull request Jun 10, 2024 that will close this issue
3 tasks
Kushdapush pushed a commit that referenced this issue Jun 10, 2024
* feat(favicon): add favicon

* feat(favicon): add favicon

* feat(favicon): add favicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants