Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You need to allow non-admins to use hotwallets for their stores (in /server/policies) #117

Open
pavlenex opened this issue Nov 28, 2024 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@pavlenex
Copy link
Contributor

Sending on-chain funds from the app generated wallet requires for some reason hot wallets to be enabled on the server? Is there a reason for this?

Screenshot 2024-11-28 at 12 22 35

To replicate:

  1. Deploy 2 apps and 1 server
  2. Register 2 different app accounts user 1 and user 2
  3. Enable Cheat mode to fund user 1 wallet
  4. Keypad pos in User 2 app, generate invoice
  5. Pay invoice from user 1 app to user 2 keypad
  6. See the error
@pavlenex
Copy link
Contributor Author

Update on this one:

Even when enabling these in Server Settings, I still get an error, though a different one. You cannot send from a cold wallet which doesn't seem to be true, since I do have a hot wallet generated on the app, but I guess in the eyes of the server it's not a hot wallet, still a server shouldn't be able to decide on this.

Screenshot 2024-11-29 at 13 53 32 Screenshot 2024-11-29 at 13 52 38

@pavlenex
Copy link
Contributor Author

However, on settings/wallet/funds I am able to send funds.
Screenshot 2024-11-29 at 13 56 15

@dennisreimann
Copy link
Member

I've consolidated what we have in the Wallet vs. Send views and on the latter sending now works from the app's wallet.

For now, external wallets (connected on the server, hot or watch-only) aren't supported and we show this hint to the user until we start to supporting hot wallets connected on the server:

grafik

@dennisreimann
Copy link
Member

@pavlenex I think we should move this one out of the first milestone into the stage in which we plan to support external hot wallets on the server. For the beta we have the warnings shown above and the ability to send from the app's internal wallet.

@pavlenex pavlenex modified the milestones: 0.0.1, 0.0.2 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog 🪵
Development

No branches or pull requests

2 participants