Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listicle Block: h4 always outputs even if empty #337

Open
acketon opened this issue May 15, 2023 · 0 comments · May be fixed by #329
Open

Listicle Block: h4 always outputs even if empty #337

acketon opened this issue May 15, 2023 · 0 comments · May be fixed by #329
Assignees
@acketon
Labels
Fixed in WP 5.7 Branch 🔥 Product bug A bug which is not directly related to a custom child theme.

Comments

@acketon
Copy link
Member

acketon commented May 15, 2023 •
edited
Loading

bu-blocks/src/blocks/listicle/listicle.js

Lines 366 to 370 in a724324

<RichText.Content
tagName="h4"
className="wp-block-editorial-listicle-header-content-dek"
value={ dek }
/>

The h4 always outputs, probably some other elements too. We should add checks to prevent output as it's causing errors in SiteImprove for empty content heading tags:

image
@acketon acketon added the 🔥 Product bug A bug which is not directly related to a custom child theme. label May 15, 2023
@acketon acketon mentioned this issue Aug 23, 2023
Merged
@acketon acketon self-assigned this Aug 23, 2023
@acketon acketon linked a pull request Aug 23, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acketon acketon

Labels
Fixed in WP 5.7 Branch 🔥 Product bug A bug which is not directly related to a custom child theme.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wp upgrade/5.7 base compatibility bu-ist/bu-blocks
1 participant
@acketon