Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a protobuf language server #343

Open
ryanberckmans opened this issue Jul 12, 2024 · 7 comments
Open

Support a protobuf language server #343

ryanberckmans opened this issue Jul 12, 2024 · 7 comments

Comments

@ryanberckmans
Copy link

Hi, it would be terrific if this package could bundle in a protobuf language server that, for example, supports jumping to a symbol definition in an import file.

Currently, I am using this package for linting and pbkit.vscode-pbkit for the language server. However the pbkit language server isn't working for me, and I'd prefer to remove pbkit and run everything through buf.

How do you jump to proto symbol definition in your editors?

@scbizu
Copy link

scbizu commented Jul 14, 2024

I am doing the same things but migrate vscode-proto3 to buf , there is a (currently not active) lsp server for buf supporting symbol definition , but currently have no integration in vscode-buf

@scbizu
Copy link

scbizu commented Jul 16, 2024

You can try my fork , I impl the vscode definition provider via bufls , but it is based on the unstable feature , I prefer not to PR to upstream.

@disjukr
Copy link

disjukr commented Oct 1, 2024

fyi. pbkit/vscode-pbkit#25 (comment)

@bufdev
Copy link
Member

bufdev commented Oct 1, 2024

We don't support the above library - we're working on adding LSP support to VSCode here, we'll keep you updated.

@scbizu
Copy link

scbizu commented Oct 2, 2024

@bufdev The LSP server implementation is better , there are other editors like Zed could integrate it as well , they are also looking for the solutions for protobuf lsp

@bufdev
Copy link
Member

bufdev commented Oct 2, 2024

We just merged an experimental LSP server via "buf beta lsp", we'll have more details soon, it's still a work in progress.

@disjukr
Copy link

disjukr commented Oct 5, 2024

@ryanberckmans
I've released vscode-pbkit v0.0.8.
While you may use vscode-buf later, for now, you can use 'Go to Definition' in vscode-pbkit with the buf v2 configuration.
If you were already using v1 or v1beta1 config, it should have been working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants