Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Initialization #276

Closed
nchegireddy opened this issue Jun 20, 2024 · 3 comments
Closed

Crash on Initialization #276

nchegireddy opened this issue Jun 20, 2024 · 3 comments

Comments

@nchegireddy
Copy link

nchegireddy commented Jun 20, 2024

Describe the bug

Bugsnag Performance crashes on initialization.

Screenshot 2024-06-20 at 4 20 18 PM

Edit 1: We were able to fix the crash by setting networkRequestCallback in the config to { _ in return .init() } which I'm not sure if it's the right approach.

Edit 2: We are using the SDK initialization and not the plist initialization.

Environment

  • BugSnag Performance library version: 1.6.0
  • BugSnag Error Monitoring library version (if any): 6.29.0
  • CocoaPods version:
  • iOS/tvOS/macOS version(s): iOS
  • Simulator or physical device: Simulator
  • Xcode version: 15.4
  • Swift version (if applicable): 5.9
@clr182
Copy link

clr182 commented Jun 21, 2024

Hi @nchegireddy

Thank you for raising this with us. We are currently working on a patch for this issue. Our current aim is to have a release out early next week. We'll be sure to keep you informed via this thread once the patch is released.

For background, The issue exists for users who call the reportNetworkRequestSpan API to report their own network spans but who don't set a callback. This crept in during a recent enhancement and unfortunately was a combination that wasn't in our end-to-end tests. You can set a no-op callback to avoid the issue until we get the patch release out.

@clr182 clr182 added bug Confirmed bug backlog We hope to fix this feature/bug in the future labels Jun 21, 2024
@eseay
Copy link

eseay commented Jun 21, 2024

Hi @nchegireddy

Thank you for raising this with us. We are currently working on a patch for this issue. Our current aim is to have a release out early next week. We'll be sure to keep you informed via this thread once the patch is released.

For background, The issue exists for users who call the reportNetworkRequestSpan API to report their own network spans but who don't set a callback. This crept in during a recent enhancement and unfortunately was a combination that wasn't in our end-to-end tests. You can set a no-op callback to avoid the issue until we get the patch release out.

@clr182 Great to know that a fix is already in the works! We landed on the same workaround of setting the no-op callback, as you mentioned. We'll keep an eye out for the patch and get that integrated as soon as it's ready.

@nchegireddy
Copy link
Author

I get no crashes on 1.6.1, so closing this issue.

@toniewypada toniewypada removed bug Confirmed bug backlog We hope to fix this feature/bug in the future labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants