feat: extend boolean expressions to allow key-value and identifiers #8658
+237
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbenavides
force-pushed
the
adrian/extend-policy-boolean-expressions
branch
from
43759ea
to
9eb76a7
Compare
etorreborre
previously approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I'm slightly uncomfortable with the ambiguity between Name and Identifier.
This PR means that I won't be able to use an identifier as an attribute name. I don't really see why a user would want to do that but people sometimes come with clever schemes.
I guess that this is ok, as long as we can revert to a more explicit policy description with (= subject.attribute_name attribute_value)
adrianbenavides
force-pushed
the
adrian/extend-policy-boolean-expressions
branch
3 times, most recently
from
dc91c36
to
6a89887
Compare
adrianbenavides
force-pushed
the
adrian/extend-policy-boolean-expressions
branch
from
6a89887
to
6e4595d
Compare
etorreborre
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policies boolean expression now support key-value and identifiers:
a=bis transformed into(= subject.a "b")a="the value"is transformed into(= subject.a "the value")I228786aeis transformed into(= subject.identifier \"I228786ae\")