From 1ecbe84fd57182b6e7b6b48b46c0bf7e2bc22e8a Mon Sep 17 00:00:00 2001 From: Jasmine Quek Date: Thu, 5 Oct 2023 09:30:06 +0800 Subject: [PATCH 1/3] add docs on potential conflicting gems with the collector --- pages/test_analytics/ruby_collectors.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pages/test_analytics/ruby_collectors.md b/pages/test_analytics/ruby_collectors.md index c6154a296c..554c2bab15 100644 --- a/pages/test_analytics/ruby_collectors.md +++ b/pages/test_analytics/ruby_collectors.md @@ -32,7 +32,7 @@ Before you start, make sure RSpec runs with access to [CI environment variables] bundle ``` -3. Add the Test Analytics code to your application in `spec/spec_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. +3. Add the Test Analytics code to your application in `spec/spec_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP` like `httplog` and `sniffer` are required before `buildkite/test_collector` to avoid conflicts. ```rb require "buildkite/test_collector" @@ -89,7 +89,7 @@ If you're already using minitest for your tests, add the `buildkite-test_collect bundle ``` -3. Add the Test Analytics code to your application in `test/test_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. +3. Add the Test Analytics code to your application in `test/test_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP` like `httplog` and `sniffer` are required before `buildkite/test_collector` to avoid conflicts. ```rb require "buildkite/test_collector" From 4cf1083778a9198f9fb70c68bf2a9791784092b6 Mon Sep 17 00:00:00 2001 From: Jasmine Quek Date: Thu, 12 Oct 2023 16:01:17 +0800 Subject: [PATCH 2/3] add commas and links to gems --- pages/test_analytics/ruby_collectors.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pages/test_analytics/ruby_collectors.md b/pages/test_analytics/ruby_collectors.md index 554c2bab15..62c2d86bd7 100644 --- a/pages/test_analytics/ruby_collectors.md +++ b/pages/test_analytics/ruby_collectors.md @@ -32,7 +32,7 @@ Before you start, make sure RSpec runs with access to [CI environment variables] bundle ``` -3. Add the Test Analytics code to your application in `spec/spec_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP` like `httplog` and `sniffer` are required before `buildkite/test_collector` to avoid conflicts. +3. Add the Test Analytics code to your application in `spec/spec_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP`, like [httplog](https://github.com/trusche/httplog) and [sniffer](https://github.com/aderyabin/sniffer), are required before `buildkite/test_collector` to avoid conflicts. ```rb require "buildkite/test_collector" @@ -89,7 +89,7 @@ If you're already using minitest for your tests, add the `buildkite-test_collect bundle ``` -3. Add the Test Analytics code to your application in `test/test_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP` like `httplog` and `sniffer` are required before `buildkite/test_collector` to avoid conflicts. +3. Add the Test Analytics code to your application in `test/test_helper.rb`, and set the BUILDKITE_ANALYTICS_TOKEN [securely](/docs/pipelines/secrets) on your agent or agents. Please ensure gems that patch `Net::HTTP`, like [httplog](https://github.com/trusche/httplog) and [sniffer](https://github.com/aderyabin/sniffer), are required before `buildkite/test_collector` to avoid conflicts. ```rb require "buildkite/test_collector" From cc2aaf400533db70b5c9e0c232281fcb4316b7a7 Mon Sep 17 00:00:00 2001 From: Jasmine Quek Date: Thu, 12 Oct 2023 16:08:50 +0800 Subject: [PATCH 3/3] add httplog to ignore list --- vale/styles/vocab.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/vale/styles/vocab.txt b/vale/styles/vocab.txt index 97bdae0ffd..ea0d062199 100644 --- a/vale/styles/vocab.txt +++ b/vale/styles/vocab.txt @@ -117,6 +117,7 @@ gzipped heroku hostname http +httplog https inlining IPs