Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not SilverStripe 4 Compatible #16

Closed
purplespider opened this issue Apr 29, 2019 · 1 comment
Closed

Not SilverStripe 4 Compatible #16

purplespider opened this issue Apr 29, 2019 · 1 comment

Comments

@purplespider
Copy link

Doesn't look like the code has been updated for SS4?

Warning: Declaration of BurnBright\ExternalURLField\ExternalURLField::setValue($url) should be compatible with SilverStripe\Forms\FormField::setValue($value, $data = NULL) in externalurlfield/src/ExternalURLField.php on line 12
@robbieaverill
Copy link
Contributor

This has been fixed in #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@purplespider @robbieaverill