-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ImportMap from go list -json' output #146
Comments
Nice catch, I wasn't aware of ImportMap. Adding support for that shouldn't be too difficult, and we should be able to add a |
If this is fixed, most likely, I can fix #134 + increase "buildability" of large projects. |
I first assumed I could reproduce this by just vendoring dependencies, but |
OK, I was able to reproduce. The cause was a package vendored in the standard library. |
Alright, I fixed the first issue on our end, but now we're failing due to Binject/debug#17. |
The only reason garble uses goobj2's ParseImportcfg function is because Binject/debug#13 isn't fixed right? Seems like the best solution might just be to fix that |
Indeed. |
We also update the "original types importer" to support ImportMap. The test now gets further along, no longer getting stuck on "path not found in listed packages". Instead, we get stuck on: error parsing importcfg: <...>/importcfg:2: unknown directive "importmap" This bug has been filed at Binject/debug#17. Until it's fixed, we can't really proceed on #146, so the net import in the test file (which triggers this case) is commented out for now. Updates #146.
Part of #134
I suppose this error appears when the output `go list -json -deps' appears:
Full output: https://gist.github.com/pagran/d2da864552406f3667f685baaa6deeac
The text was updated successfully, but these errors were encountered: