Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module import error from Octane app #122

Closed
balinterdi opened this issue Aug 22, 2019 · 7 comments
Closed

Module import error from Octane app #122

balinterdi opened this issue Aug 22, 2019 · 7 comments

Comments

@balinterdi
Copy link
Contributor

Trying to use ember-link (version 1.0.1) in an Octane app and I get the following error:

Could not find module ember-link/components/link/template imported from sac-sac-mate/components/link/template

I don't think it matters but that's how I try to use it from the template:

<Link @route="players.player" @models={{array player}} as |link|>
  <a
   class="no-underline text-blue hover:text-blue-darker w-350px"
   href={{link.href}}>
   <PlayerCard @player={{player}} />
  </a>
</Link>

It seems that the problem comes from the addon's merged app tree but I'm not sure how to fix it (or whether that's indeed the problem).

@rwjblue
Copy link

rwjblue commented Aug 22, 2019

@balinterdi - Mind making a demo repo (or linking to a branch or something)? I'm guessing that the addon/components/ember-link/template.hbs is not being processed by the colocation branch of ember-cli-htmlbars but I'm not sure...

@balinterdi
Copy link
Contributor Author

balinterdi commented Aug 22, 2019

@rwjblue Sure, the app/branch I'm using it in is here: https://github.com/balinterdi/sac-sac-mate/tree/ember-link . It's not a public repo but I added you as a collaborator.

FWIW, I tried using the latest release of ember-cli-htmlbars to see if that makes a difference but it didn't. I didn't change any other dependency, though, so I'm not sure if that experiment tells us something.

GitHub
GitHub is where people build software. More than 40 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@buschtoens
Copy link
Owner

Are you by any chance using a podModulePrefix?

@buschtoens
Copy link
Owner

Ah sorry. This shouldn't matter. The colocation thing might be a good hint though. Unfortunately I cannot access your repository.

@balinterdi
Copy link
Contributor Author

@buschtoens Thank you for your reply. I don't use podModulePrefix. I added you to the repo if you have time to take a look.

@balinterdi
Copy link
Contributor Author

The latest version of the add-on (1.1.0-beta.5) works great with the first fully-Octane Ember version (3.15.0) so I'll happily close this.

@buschtoens
Copy link
Owner

Awesome! Thank you for following up on this! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants