fix(Link): Use currentTransitionStack to enable auto-tracking
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`currentURL` appears to update when the transition starts, but not anymore when it has ended. This leads to `isActive` not updating correctly if the `model()` hook is taking too long to load data. The `currentTransitionStack` however is changing in the `routeDidChange` event handler, which ensures that `isActive` (and friends) are updating at the right time.
buschtoens
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Looks great! Thank you. 💝
I wish we had proper tests for #42, but we can add them later. And since this PR doesn't break anything, it's shipping time. 🚢 😄
buschtoens
changed the title
currentTransitionStack to enable auto-trackingcurrentTransitionStack to enable auto-tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentURLappears to update when the transition starts, but not anymore when it has ended. This leads toisActivenot updating correctly if themodel()hook is taking too long to load data. ThecurrentTransitionStackhowever is changing in therouteDidChangeevent handler, which ensures thatisActive(and friends) are updating at the right time.If I understand the issue correctly, this should resolve #42.