Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in a project with e-decorators v6 #51

Closed
Windvis opened this issue May 8, 2019 · 3 comments
Closed

Doesn't work in a project with e-decorators v6 #51

Windvis opened this issue May 8, 2019 · 3 comments

Comments

@Windvis
Copy link

Windvis commented May 8, 2019

We're getting the following console error when using the pre-octane version in an Ember 3.9 + Decorators v6 project:

Error: Assertion Failed: computed decorators must return an instance of an Ember ComputedProperty descriptor, received [object Function]

I searched the discord and it seems that this is related to the usage of e-decorators v5 in this addon.

Are there any plans for updating the pre-octane version? :) If not, I totally understand. We can always use the ember-router-helpers as an (more verbose) alternative.

@buschtoens
Copy link
Owner

buschtoens commented May 8, 2019

The trouble is that sparkles-component only works with v5 ember-decorators (stage 2). I'll try to refactor the 0.x series away from sparkles-component and then update to v6, timeboxed.

@buschtoens
Copy link
Owner

buschtoens commented May 8, 2019

I published two new releases:

  • v0.3.0: Drops sparkles-component, but keeps ember-decorators@5.* (stage 2 decorators).
  • v0.4.0: Drops sparkles-component and ember-decorators entirely. Uses the vanilla Ember.js decorators via ember-decorators-polyfill (stage 1 decorators).

Let me know, if you encounter any issues. 😊

@Windvis
Copy link
Author

Windvis commented May 8, 2019

Man... You are insanely fast 🎉 v0.4.0 works like a charm, thanks a lot!

I didn't know sparkles wasn't compatible with v6, that explains all the @tracked errors I was getting 😄in my fork.

Thanks again, you are a legend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants