Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with stable ember-source/types #784

Closed
HeroicEric opened this issue Aug 18, 2023 · 3 comments
Closed

Incompatible with stable ember-source/types #784

HeroicEric opened this issue Aug 18, 2023 · 3 comments

Comments

@HeroicEric
Copy link

When using the stable TypeScript Types in Ember 5.1 there is an issue with the types for ember-link:

node_modules/ember-link/dist/services/link-manager.d.ts:39:35 - error TS2315: Type 'PublicTransition' is not generic.

39     get currentTransitionStack(): Transition<unknown>[] | undefined;
@villander
Copy link
Contributor

I think that's a related issue after bumping my codebase to tsconfig/ember 3.x I got a similar error

Cannot find module 'ember-link/dist/services/link-manager' or its corresponding type declarations.

@gossi
Copy link
Collaborator

gossi commented Jan 28, 2024

Oh, I realized I have no notifications for this repo turned on. For all ember v5 releases I had issues with the types. Only at ember 5.6 those were resolved and the last blocker was ember-link indeed, which brought me here.

I fixed it with #786

Given the type issues with ember v5 releases, you are advised to upgrade to ember 5.6.

@gossi gossi closed this as completed Jan 28, 2024
@gossi
Copy link
Collaborator

gossi commented Jan 28, 2024

It's released as 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants