fix: Fix incompatibility with ember-source/types #787
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #784
Currently
LinkManagerService#currentTransitionStack()
has an implicit return type:Which results in the following type declaration:
Which causes errors when using the types from
ember-source/types
becauseTransition
is not generic.Adding an explicit return type to
currentTransitionStack
seems to prevent TypeScript from expandingTransition[]
toTransition<unknown>[]
.Here is the resulting type after the change:
I'm guessing there is a better way to deal with this but I'm not sure what it is.