We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getLinkParamsFromRouteInfo
RouteInfo
At the moment, only paramNames on the leaf RouteInfo instance is used here: https://github.com/buschtoens/ember-link/blob/main/ember-link/src/services/link-manager.ts#L100
paramNames
But I think we need to traverse up the entire tree (using the parent property) to collect all models?
parent
Otherwise, Ember's router throws an error when creating links using the fromURL option, and providing a URL with e.g. multiple dynamic segments.
fromURL
The text was updated successfully, but these errors were encountered:
No branches or pull requests
At the moment, only
paramNames
on the leaf RouteInfo instance is used here:https://github.com/buschtoens/ember-link/blob/main/ember-link/src/services/link-manager.ts#L100
But I think we need to traverse up the entire tree (using the
parent
property) to collect all models?Otherwise, Ember's router throws an error when creating links using the
fromURL
option, and providing a URL with e.g. multiple dynamic segments.The text was updated successfully, but these errors were encountered: