Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add downvote power slider with confirmation #2182

Closed
wants to merge 8 commits into from
Closed

feat: add downvote power slider with confirmation #2182

wants to merge 8 commits into from

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Feb 4, 2019

Fixes #2126

Changes

  • Added downvote slider analogically to the upvote's one
  • Updated Slider component indicator

Test plan

  • Make sure you have 'Enable slider' checked in settings or your rank is Dolphin or higher
  • Select a random post and go to the comments' section
  • Click dislike

Demo (optional)

image
image

@th7nder th7nder requested a review from Sekhmet as a code owner February 4, 2019 15:59
@Sekhmet
Copy link
Contributor

Sekhmet commented Feb 18, 2019

I think it might be a good idea to always display slider (for upvotes & downvotes) no matter user rank. Otherwise we will have to default to some downvote percent which is not ideal.

Sekhmet
Sekhmet reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

@th7nder th7nder closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downvote button: add confirm + slider
2 participants
@th7nder @Sekhmet