Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heater control as a ScalarCmd #666

Open
blackspherefollower opened this issue Oct 26, 2024 · 3 comments
Open

Heater control as a ScalarCmd #666

blackspherefollower opened this issue Oct 26, 2024 · 3 comments
Assignees
Labels
Features New things to add to the project

Comments

@blackspherefollower
Copy link
Collaborator

I think that heaters are a good fit as a ScalarCmd actuator type; however, there's at least 2 kinds of control I've seen:

  1. 0 is off, 23-40 are target temperatures in Celsius (thinking about it, I'm actually surprised I've not spotted some cursed device using F)
  2. 0 is off, 1+ are increments without any clear mapping between value and target temperature (often it's just on/off)

In both cases, I think step range will suffice to describe the control (except for the 0=off in case 1?)

@blackspherefollower blackspherefollower added the Features New things to add to the project label Oct 26, 2024
@qdot
Copy link
Member

qdot commented Nov 16, 2024

I feel like 0 = off, 1-17 maps to 23-40 for case 1 works well enough, since we're working in the abstract on this anyways?

@blackspherefollower
Copy link
Collaborator Author

Do all the client APIs still send 0.0-1.0 doubles? If so, then let's stick with any sort of offsetting in the protocol implementation for now, which means we just need a heater actuator type and we can iterate on things later if we want to do less abstract.

@qdot
Copy link
Member

qdot commented Nov 16, 2024

Yup, they all do, so it should be fine as an actuator type addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features New things to add to the project
Projects
None yet
Development

No branches or pull requests

2 participants